Fix potential panic on AdjacencyMap #157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the store could theoretically be updated without the use of the main `AddVertex` and `AddEdge` APIs (which does some input validation), calculating the `AdjencyMap` could provoke an "assignment to entry in nil map" panic if the store reported edges that were between unknown vertices. Since the edges are always between known vertices, it is an error to try and match a missing source vertex from the vertex set. If that happens, it is a data desynchronization error that we report to the user. In order to test this pathological case, we needed to modify the test to use the store directly because the "front-facing" API would not allow us to add Edges on missing vertex. fixes dominikbraun#102 Signed-off-by: davidovich <[email protected]>
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the store could theoretically be updated without the use of the
main
AddVertexandAddEdgeAPIs (which does some input validation),calculating the
AdjencyMapcould provoke an "assignment to entry innil map" panic if the store reported edges that were between unknown
vertices.
Since the edges are always between known vertices, it is an error to try
and match a missing source vertex from the vertex set. If that happens,
it is a data desynchronization error that we report to the user.
In order to test this pathological case, we needed to modify the test to
use the store directly because the "front-facing" API would not allow us
to add Edges on missing vertex.
fixes #102
Signed-off-by: davidovich [email protected]